Monday, November 20, 2017

[Discuss-gnuradio] nlog10: do we consider "normalizes log10(x <= 0) to -18" as API?

Hi Folks,

I was about to commit a PR VOLKizing nlog10 [1], but it struck me that
my processor (imho, correctly) says that log(0) == nan and log(-10) ==
nan.

Whereas the old nlog10 test case asserts that it's log_10(x<=0) == -18.

So, am I allowed to break that assertion for the greater mathematical
appropriateness and speed?

Best regards,
Marcus

[1]
https://github.com/marcusmueller/gnuradio/tree/blocks_volkized_nlog10

No comments:

Post a Comment