Tuesday, July 14, 2015

Re: [Discuss-gnuradio] possible bug in gr_modtool

The OP's point is that in gr-modtool's docs/doxygen/CMakeLists.txt, this
command is:
{{{
add_custom_command(
OUTPUT ${BUILT_DIRS}
COMMAND ${DOXYGEN_EXECUTABLE} ${CMAKE_CURRENT_BINARY_DIR}/Doxyfile
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
COMMENT "Generating documentation with doxygen"
)
}}}
which is -without- the DEPENDS. Hence, this command will be executed
just once, the first time, no matter if any dependencies change & make
is executed again. The only way to get it to rerun is to redo the
original cmake command.

OTOH, the top-level docs/doxygen/CMakeLists.txt -does- contain the
DEPENDS clause, which, assuming the ${GENERATED_DEPS} is valid, should
redo the doxygen command when any of the doc sources change (or
something along those lines).

I'm thinking adding in the current binary (build) directory isn't the
right way to go, but I'm just not familiar enough with the modtool docs
to know what to add as DEPENDS there. - MLD

On Tue, Jul 14, 2015, at 12:57 PM, Martin Braun wrote:
> On 14.07.2015 07:11, Michael Dickens wrote:
> > Hi Federico - Yes, that does seem like a bug. Looking at the top-level
> > docs/doxygen/CMakeLists.txt, this command is:
> > {{{
> > add_custom_command(
> > OUTPUT ${BUILT_DIRS}
> > COMMAND ${DOXYGEN_EXECUTABLE} ${CMAKE_CURRENT_BINARY_DIR}/Doxyfile
> > WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
> > DEPENDS ${GENERATED_DEPS}
> > COMMENT "Generating documentation with doxygen"
> > )
> > }}}
>
> Doxygen has no states; if something changes, you need to rerun it
> entirely. I would have thought this syntax does the right thing,
> assuming $GENERATED_DEPS actually holds all the files that can be
> changed.
> So, this might also be a CMake issue.

_______________________________________________
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

No comments:

Post a Comment