core/generator/flow_graph.py.mako:214
self.${blk.name}.set_block_alias(${blk.params['alias'].get_evaluated()})
Just remove quotes. NOTE: this WILL BREAK any existing flowgraphs that set the block alias, and they will have to add quotes around the current block alias. I can't think of any way to preserve backward compatibility.
While we are on the subject of aliases, can we also make a one-line change to set the thread name based on the alias rather than the block name!
________________________
Eugene Grayver, Ph.D.
Aerospace Corp., Principal Engineer
Tel: 310.336.1274
________________________
From: Paul Atreides <maud.dib1984@gmail.com>
Sent: Wednesday, September 1, 2021 1:46 PM
To: Eugene Grayver <eugene.grayver@aero.org>
Cc: discuss-gnuradio@gnu.org <discuss-gnuradio@gnu.org>
Subject: Re: Block alias
Sent: Wednesday, September 1, 2021 1:46 PM
To: Eugene Grayver <eugene.grayver@aero.org>
Cc: discuss-gnuradio@gnu.org <discuss-gnuradio@gnu.org>
Subject: Re: Block alias
I'd be happy to help you submit a pull request for the one line that needs to be changed.
You can message me directly if you'd like help with that.
You can message me directly if you'd like help with that.
<end transmission>
On Sep 1, 2021, at 13:58, Eugene Grayver <eugene.grayver@aero.org> wrote:
I'd like to suggest a minor change to the way block alias is handled in GRC. Currently it is treated as a string. It should be treated as 'any'. The current approach does not scale to large flowgraphs, especially with multiple hierarchical blocks. We should be able to set the alias based on parameters/variables. Should be a one-line change in GRC.
While on the topic, I don't recall if gr 3.9 has finally exposed the set_block_alias on python blocks. My old version still does not.
________________________
Eugene Grayver, Ph.D.
Aerospace Corp., Principal Engineer
Tel: 310.336.1274
________________________
No comments:
Post a Comment